oEtG Forum

Spectate errors

Chapuz · 4 · 3982

Chapuz

  • Member
  • **
    • Posts: 506
I got some errors while spectating flyingcat vs shinki, maybe I touched something...

Spectate is an awsome tool, wonderfully used in EtG and would be awesome to have it well implemented here. Entering in mid-game and have the game status recorded in what players did each turn is something everyone will love.

Uncaught ReferenceError: game is not defined, http://etg.dek.im/etgify.js, 250, 40, ReferenceError: game is not defined

Uncaught TypeError: Cannot read property 'toString' of undefined, http://etg.dek.im/etgify.js, 8230, 25, TypeError: Cannot read property 'toString' of undefined
TypeError: Cannot read property 'toString' of undefined
Uncaught TypeError: Cannot read property 'spelldmg' of undefined, http://etg.dek.im/etgify.js, 3684, 3,

Uncaught TypeError: Cannot read property 'delay' of undefined, http://etg.dek.im/etgify.js, 3478, 3, TypeError: Cannot read property 'delay' of undefined
Uncaught TypeError: Cannot read property 'status' of undefined, http://etg.dek.im/etgify.js, 4031, 3, TypeError: Cannot read property 'status' of undefined


timpa

  • Member
  • **
    • Posts: 459
  • New to Elements
I was spectating their 3rd match and the HP changes didn't made any sense (was getting errors about things being undefined at each turn, but forgot to note them down).

It would also be interesting to hide the hand of the player you are spectating.
:chroma :gravity :time


serprex

  • Global Moderator
  • *****
    • Posts: 1483
Hiding hand of spectated player is incomplete; need to add capability for P1 to be cloaked

Error is about mulligan being sent when no longer in mulligan phase. Possible for that to happen if you hit space bar to accept hand. Tho we don't attach keyboard listeners for spectator. So weird
« Last Edit: April 26, 2015, 07:17:01 pm by serprex »


serprex

  • Global Moderator
  • *****
    • Posts: 1483
Initial spectator logic has pretty much been removed & the PvP protocol's been revamped & the rendering logic's been abstracted so that when it makes a return this all won't be relevant. So moving this to Fixed Bugs