oEtG Forum

General Category => Game Suggestions => Completed Game Suggestions => Topic started by: cg on May 12, 2018, 05:32:20 pm

Title: make forum deck tag and web deck viewer use the same sort function as ingame
Post by: cg on May 12, 2018, 05:32:20 pm
(https://i.imgflip.com/e8g0b.jpg)
Title: Re: make forum deck tag and web deck viewer use the same sort function as ingame
Post by: serprex on May 12, 2018, 05:56:29 pm
Anti made the mistake of having the deck tag on original sort. It stopped 2 good uses: CuCN's deck tag art, & arena deck posts

Compromise: have deck editor produce sorted codes
Title: Re: make forum deck tag and web deck viewer use the same sort function as ingame
Post by: cg on May 12, 2018, 06:22:02 pm
Anti made the mistake of having the deck tag on original sort. It stopped 2 good uses: CuCN's deck tag art, & arena deck posts

Compromise: have deck editor produce sorted codes

good enough, though sad that five years of history won't be retroactively fixed

will deck editor's sorting result in unupped/upped/shiny/unshiny versions of a card all being next to each other? that, along with same-element cards being next to each other, is basically what i care about. it's super difficult to read currently when you have the same card in 2+ places

might actually be best to just bandaid this one until card code revision happens now that i think about it

edit: fwiw i'd be perfectly comfortable adding a "nosort" flag to forum deck, e.g. (deck nosort name=arenadeck) to tell it to not sort for when people want to post an arena deck with the arena card shown first. i also am perfectly comfortable with people's arena decks being sorted.
Title: Re: make forum deck tag and web deck viewer use the same sort function as ingame
Post by: serprex on May 12, 2018, 06:51:35 pm
Fixed ingame deck code ordering: https://github.com/serprex/openEtG/commit/2fd39181fd67f1e4b2e7fafa78d7a4501000dc7d